Community
Participate
Working Groups
CommitBuilder.writeGpgSignatureString() produces output that ends with " -----END PGP SIGNATURE-----\n \n". While the extra empty line is properly prefixed with a blank and thus part of the header, and while this does not cause any trouble for standard git/gpg, it is a bit unexpected and might be one cause for Gitlab not being able to verify signatures created by JGit. See bug 564386 comment 4. It's fairly simple to avoid this extra empty line, so we should do so.
Created attachment 283345 [details] JGit commit with trailing empty line in gpgsig
Created attachment 283346 [details] git/gpg commit without this trailing line
New Gerrit change created: https://git.eclipse.org/r/165173
Created attachment 283347 [details] JGit signed commit after fix (In reply to Eclipse Genie from comment #3) > New Gerrit change created: https://git.eclipse.org/r/165173
finally it's verified :) from the link you provided in #564386 comment 4, i think it's caused by https://gitlab.com/gitlab-org/gitaly/-/issues/2545 so i upgrade our gitlab from 12.8.1 to 12.10.11 and problem solved. again, thanks for you effort ------------------- eclipse 4.7.1a, egit 5.8.0, gitlab 12.10.11 -> ok eclipse committer 2020-03, egit 5.8.0 + patch #564386, #564428, gitlab 12.10.11 -> ok
Good find; thanks a lot for digging deeper, and for verifying that the JGit changes are fine.
Gerrit change https://git.eclipse.org/r/c/jgit/jgit/+/165173 was merged to [master]. Commit: http://git.eclipse.org/c/jgit/jgit.git/commit/?id=9b033a1b6da1193dbedca80c217af748ae546629