Community
Participate
Working Groups
Created attachment 283356 [details] Project Explorer Stripes Project Explorer is showing some background stripes when using Dark Theme based on uncommitted git changes.
I think that comes from EGit. Thomas, please comment.
This is egit's uncommitted changes background color preference. If possible, it could help to not use egit's uncommitted changes background color preference by default, and only use it in cases where the user set changed the color themselves. Hard coding this color preference to be the same as the platform dark theme will most likely break the light theme, and it would prevent custom eclipse theme plugin's from receiving the upstream fix.
> This is egit's uncommitted changes background color preference. Can't colors describe a "defaultTo" to inherit from like fonts do?
(In reply to Mickael Istria from comment #3) > > This is egit's uncommitted changes background color preference. > > Can't colors describe a "defaultTo" to inherit from like fonts do? I'm not sure I haven't looked into it. If someone else know's please chime in :) I'll look into it when I have a moment otherwise
Looks like the dark theme changed its background color? Or maybe the EGit colors were never quite right. The colors are configurable in Preferences->General->Appearance->Colors & Fonts, "Ignored resource(Background)" and "Uncommitted Change (Background)". I'm not even sure EGit should define these colors in CSS; they're set in plugin.xml to refer to COLOR_LIST_FOREGROUND and COLOR_LIST_BACKGROUND, so if the theme switches, these colors should also switch automatically (unless customized by the user) and thus not need an override in /org.eclipse.egit.ui/css/e4-dark_egit_prefstyle.css . Is that correct, Lars?
But also see bug 430741 and bug 496585.
(In reply to Thomas Wolf from comment #5) > Is that correct, Lars? This could be validated via the preference spy from the e4 tools. Activate it, switch themes and see if the colors get adjusted.
Just removing these two color pairs from the EGit CSS would indeed solve (on 2020-03) the background problem, but brings back the "black text on nearly black background" problem from bug 496585. Given that my preferred resolution for this "WONTFIX". If the dark theme background color has changed between Neon and today, whatever change we make in the EGit CSS (such as updating the background to match current dark theme) will be wrong on some Eclipse version. (Since the background changes correctly on 2020-03 when the CSS definitions in EGit are removed, I suppose the theme engine still has a bug somewhere about not updating COLOR_LIST_FOREGROUND correctly.)
New Gerrit change created: https://git.eclipse.org/r/c/egit/egit/+/165993
Gerrit change https://git.eclipse.org/r/c/egit/egit/+/165993 was merged to [master]. Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=72e23e1985f2fc88c2abcd52f31e90512c92d861
Thanks, Thomas and Andrew.