Bug 566326 - Change id outwits Ctrl-A
Summary: Change id outwits Ctrl-A
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: 5.9   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 566327 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-08-24 12:32 EDT by Ed Willink CLA
Modified: 2020-08-25 16:18 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Willink CLA 2020-08-24 12:32:12 EDT 
In the staging view when about to commit.

Use Ctrl-A to select all the garbage such as Change Id in the commit text

Use Ctrl-Space and select a previous text

Chnage-Id persists despite being in the paste region selected by Ctrl-A.
Comment 1 Thomas Wolf CLA 2020-08-24 16:58:07 EDT 
*** Bug 566327 has been marked as a duplicate of this bug. ***
Comment 2 Thomas Wolf CLA 2020-08-25 14:09:15 EDT 
Funny description. Took me a moment to understand what you probably mean:

"Insertion of a content assist proposal in the commit text area does not replace the text selection if there is one, but should."

Is that the problem that you see?
Comment 3 Eclipse Genie CLA 2020-08-25 14:23:43 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/egit/egit/+/168207
Comment 4 Ed Willink CLA 2020-08-25 15:09:42 EDT 
(In reply to Thomas Wolf from comment #2)
> Funny description. Took me a moment to understand what you probably mean:
> 
> "Insertion of a content assist proposal in the commit text area does not
> replace the text selection if there is one, but should."
> 
> Is that the problem that you see?

Yes. I seem to spend increasing amounts of time trying to get rid of the useless Change Id and appear to be losing. EGIT wins by bloating my commits with garbage. Once upon a time EGIT was well-behaved and let me choose my own commit text without corruption.
Comment 5 Thomas Wolf CLA 2020-08-25 15:25:18 EDT 
If you don't want to use Gerrit, don't configure the repo for Gerrit. If you do use Gerrit, then it's a very bad idea not to have a change-id.

Thanks for confirming that my rephrasing of the problem is what you see.