Bug 385484 - History View, column 'comment' removes tabs
Summary: History View, column 'comment' removes tabs
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 5.6   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 5.6   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-19 06:06 EDT by Alim Özdemir CLA
Modified: 2019-11-28 15:36 EST (History)
1 user (show)

See Also:

Attachments
image of two tabs being removed (34.01 KB, image/png)
2019-11-27 20:29 EST, Alim Özdemir CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alim Özdemir CLA 2012-07-19 06:06:13 EDT 
Build Identifier: 20120614-1722

In the comment column of Team->Show History, <TAB>s are left out completely.
Words are merged.

At least <TAB> should be replaced with a single <SPACE> or something.

Reproducible: Always

Steps to Reproduce:
1. Commit file (e.g. SVN) using <TAB>s in the commit message
2. See Team->Show history
3. All tabs removed, Words merged.
Comment 1 Lars Vogel CLA 2019-11-27 07:09:40 EST 
This bug hasn't had any activity in quite some time. Maybe the problem got
resolved, was a duplicate of something else, or became less pressing for some
reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it.
The information can be, for example, that the problem still occurs, that you
still want the feature, that more information is needed, or that the bug is
(for whatever reason) no longer relevant.

If the bug is still relevant, please remove the stalebug whiteboard tag.
Comment 2 Alim Özdemir CLA 2019-11-27 20:29:38 EST 
Created attachment 280804 [details]
image of two tabs being removed
Comment 3 Alim Özdemir CLA 2019-11-27 20:30:33 EST 
Sadly, this bug is still present in current eclipse (2019‑09).
See attached image history_tabs_e383a2c0f3.png for history view of a git commit with 2 tabs and one space.
Comment 4 Eclipse Genie CLA 2019-11-28 02:54:18 EST 
New Gerrit change created: https://git.eclipse.org/r/153521
Comment 5 Eclipse Genie CLA 2019-11-28 04:21:20 EST 
Gerrit change https://git.eclipse.org/r/153521 was merged to [stable-5.6].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=3c4040f6699324ea7fe6aade985fb8252a308b12
Comment 6 Thomas Wolf CLA 2019-11-28 09:04:12 EST 
Thanks, Alim, for the report and the follow-up. Sorry it took so long for such a minor fix, but the EGit team probably never saw this because it was filed away under "Team" and comment 0 mentioned SVN.

Will be fixed in the upcoming EGit 5.6.0 release.
Comment 7 Alim Özdemir CLA 2019-11-28 15:36:56 EST 
Thanks all! Excited for Eclipse IDE 2019-12.