Bug 463939 - Commit message in history view does not scroll to cursor position
Summary: Commit message in history view does not scroll to cursor position
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 5.6   Edit
Assignee: Thomas Wolf CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-05 11:10 EDT by Michael Keppler CLA
Modified: 2019-10-12 11:49 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Keppler CLA 2015-04-05 11:10:32 EDT
Have a commit with a long commit message in the history view. Scroll down using the cursor-down key. At least on my Windows system this does not scroll the view scrollbars, i.e. the cursor goes down into the non visible part of the text, while the top part of the commit message remains visible.
Comment 1 Matthias Sohn CLA 2015-04-14 08:55:22 EDT
this problem also exists on Mac
Comment 2 Michael Keppler CLA 2019-10-05 02:32:36 EDT
This seems to be caused by a layout I don't really understand: The SourceViewer displaying the commmit message is as big as the full text height (i.e. it has no scrollbars), and it is embedded in a scrolled composite, which adds the scrollbars.

Can't we get rid of the scrolled composite and have the SourceViewer do the scrolling instead.
Comment 3 Thomas Wolf CLA 2019-10-05 16:07:05 EDT
It's not that easy. The composite provides a combined scroll over the commit message viewer and the diff viewer below.
Comment 4 Eclipse Genie CLA 2019-10-06 09:02:17 EDT
New Gerrit change created: https://git.eclipse.org/r/150653
Comment 5 Eclipse Genie CLA 2019-10-09 08:51:03 EDT
Gerrit change https://git.eclipse.org/r/150653 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=d83e193d8e917adf3c1ee2d88a26a8ef9a27f27f
Comment 6 Thomas Wolf CLA 2019-10-09 08:58:24 EDT
Re your comment that scrolling across both nested viewers didn't work: I found a way to make this work for caret navigation with the arrow keys. Page-up/down won't work correctly though, since the underlying StyledText just moves to the end of the document. But line-up/down could be made to work.

Combined selection over the two widgets is not possible.
Comment 7 Eclipse Genie CLA 2019-10-09 15:55:43 EDT
New Gerrit change created: https://git.eclipse.org/r/150858
Comment 8 Eclipse Genie CLA 2019-10-12 11:49:36 EDT
Gerrit change https://git.eclipse.org/r/150858 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=1d561fe298e669152761fa2909709c845c4a487d