Bug 512457 - In staging view, "Commit and Push..." button should be "Push HEAD..." when there is nothing to commit
Summary: In staging view, "Commit and Push..." button should be "Push HEAD..." when th...
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 4.6   Edit
Hardware: All All
: P3 enhancement with 1 vote (vote)
Target Milestone: 5.8   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: usability
: 520496 545729 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-02-20 13:57 EST by Marc-André Laperle CLA
Modified: 2020-05-15 05:03 EDT (History)
7 users (show)

See Also:


Attachments
Proposal 1 (12.96 KB, image/png)
2019-06-14 16:56 EDT, Wim Jongman CLA
no flags Details
Do we want most of these options? (5.86 KB, image/png)
2019-06-14 16:58 EDT, Wim Jongman CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marc-André Laperle CLA 2017-02-20 13:57:11 EST
For example, at the end of a rebase (after I pressed continue), it would be nice if 
the "commit and push" could be changed to "push" so I don't have to go 
anywhere else to push the change I just completed. Otherwise, if I press "commit and push", it complains that I have no staged files. Right now, once my rebase is completed, I have to resort to opening another view, like the Repositories view, in order to push.

I think this could be generalized so that when there is no staged file, the button could be just "Push".
Comment 1 Marc Khouzam CLA 2017-02-21 09:20:17 EST
+1

I always use "Commit and Push" as my wait to push code to Gerrit (would apply just as well to a direct push to Git).

Currently, I usually have to press the "Amend commit" button just to do the "Commit and Push".  The proposed changed would improve things nicely.

The "Commit" button could also be grayed out in that case.
Comment 2 Wim Jongman CLA 2019-03-25 04:42:51 EDT
*** Bug 520496 has been marked as a duplicate of this bug. ***
Comment 3 Wim Jongman CLA 2019-03-25 04:43:10 EDT
*** Bug 545729 has been marked as a duplicate of this bug. ***
Comment 4 Mickael Istria CLA 2019-06-13 05:07:39 EDT
At the moment, this "issue" is the most annoying one I see with EGit. The workaround to get back to another view, find the node, right-click > Team > Push... is a lot of steps from an operation I typically want to perform often when I'm working on the staging view.
Comment 5 Wim Jongman CLA 2019-06-13 06:05:31 EDT
(In reply to Mickael Istria from comment #4)
> At the moment, this "issue" is the most annoying one I see with EGit. The
> workaround to get back to another view, find the node, right-click > Team >
> Push... is a lot of steps from an operation I typically want to perform
> often when I'm working on the staging view.

It is sharing number #1 with the missing Pull... The same workflow applies when you realize you have to pull before you push.
Comment 6 Matthias Sohn CLA 2019-06-13 07:58:50 EDT
+1 this sounds like a good idea

maybe someone wants to scratch this itch ?
Comment 7 Wim Jongman CLA 2019-06-13 09:01:49 EDT
I'm working heavily with the EGit and JGit API at the moment. Time is sparse but I can probably fix this for the 2019/9 simrel. If someone else wants to take it, that's fine too.
Comment 8 Mickael Istria CLA 2019-06-13 10:37:11 EDT
I'd be ready to put a few dozen of bucks in a bounty for this one ;)
Comment 9 Wim Jongman CLA 2019-06-13 11:07:53 EDT
(In reply to Mickael Istria from comment #8)
> I'd be ready to put a few dozen of bucks in a bounty for this one ;)

I only accept frosty beverages..
Comment 10 Mickael Istria CLA 2019-06-13 11:08:55 EDT
(In reply to Wim Jongman from comment #9)
> I only accept frosty beverages..

a few dozens as well?
Comment 11 Wim Jongman CLA 2019-06-13 13:12:52 EDT
(In reply to Mickael Istria from comment #10)
> (In reply to Wim Jongman from comment #9)
> > I only accept frosty beverages..
> 
> a few dozens as well?

Just one is enough :D
Comment 12 Wim Jongman CLA 2019-06-14 16:56:51 EDT
Created attachment 278948 [details]
Proposal 1

I have built this, and it works fine, but what options do we really want here? Shouldn't we put a large chunk of the Git repo menu here?
Comment 13 Wim Jongman CLA 2019-06-14 16:58:21 EDT
Created attachment 278949 [details]
Do we want most of these options?
Comment 14 Mickael Istria CLA 2019-06-14 17:26:46 EDT
(In reply to Wim Jongman from comment #12)
> I have built this, and it works fine, but what options do we really want
> here? Shouldn't we put a large chunk of the Git repo menu here?

I'm personally not using view toolbar much (I hate it to be honest) and am mostly using the regular buttons below the Git commit message box.
Can the change just be renaming the "Commit and Push" button to just "Push" when there is nothing staged, and to link to the Push wizard instead of showing an error in that case?
Comment 15 Eclipse Genie CLA 2020-05-09 09:29:30 EDT
New Gerrit change created: https://git.eclipse.org/r/162746
Comment 16 Thomas Wolf CLA 2020-05-15 05:03:06 EDT
Thanks, Mickael!