Bug 525685 - Git Staging view should disable commit buttons until files are staged
Summary: Git Staging view should disable commit buttons until files are staged
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 5.8   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-06 10:42 EDT by Andreas Sewe CLA
Modified: 2020-04-04 09:11 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Sewe CLA 2017-10-06 10:42:08 EDT 
I just got a "Committing is not possible: There are no staged files" dialog when hitting "Commit" in the Git Staging view. While the dialog was correct, I was a bit surprised by it; IMHO, it would be a nicer UX if the Commit button was simply disabled until at least one file was staged.
Comment 1 Thomas Wolf CLA 2017-10-15 16:11:49 EDT 
(In reply to Andreas Sewe from comment #0)
> it would be a nicer UX if the Commit
> button was simply disabled until at least one file was staged.

... or amend mode was switched on.

See also the comments on bug 518996.
Comment 2 Eclipse Genie CLA 2020-04-04 07:02:27 EDT 
Gerrit change https://git.eclipse.org/r/159167 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=0498bada02b90e1c5505cf21b7000278a5eaae91
Comment 3 Eclipse Genie CLA 2020-04-04 08:07:57 EDT 
New Gerrit change created: https://git.eclipse.org/r/160478
Comment 4 Eclipse Genie CLA 2020-04-04 09:11:06 EDT 
Gerrit change https://git.eclipse.org/r/160478 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=4f200f78f23249f34cf2365def5b1eee04df67c4