Bug 536171 - [Dark Theme] Branch label color is too light
Summary: [Dark Theme] Branch label color is too light
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: 5.10   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2018-06-22 04:54 EDT by Lars Vogel CLA
Modified: 2020-09-14 03:53 EDT (History)
2 users (show)

See Also:

Attachments
Screenshot (405.93 KB, image/png)
2018-06-22 04:54 EDT, Lars Vogel CLA 		no flags Details
Screenshot (50.60 KB, image/png)
2020-08-27 10:59 EDT, Lars Vogel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2018-06-22 04:54:49 EDT 
Created attachment 274584 [details]
Screenshot

The branch label color is too light and really sticks out. Could you use a preference for this color and style it in your dark theme?
Comment 1 Thomas Wolf CLA 2018-06-23 08:02:58 EDT 
Which color? I presume you mean the "other references": HEAD, FETCH_HEAD, ORIG_HEAD, and so on.

There are quite a few colors involved; see class SWTPlotRenderer. They're currently all hard-coded, and for each ref type, there are actually two colors: one for the border and one for the fill. And the text color is hard-coded to black.

To avoid inconsistencies, one would probably want to use preferences for the fill colors only and derive the border colors automatically, and also automatically choose black or a light gray depending on whether the background is dark or light. With some care, such automatic determination of colors should be possible; we do something similar already for the overview ruler in the DiffEditorPage.
Comment 2 Lars Vogel CLA 2020-05-14 05:10:08 EDT 
(In reply to Thomas Wolf from comment #1)
> Which color? I presume you mean the "other references": HEAD, FETCH_HEAD,
> ORIG_HEAD, and so on.

Yes
Comment 3 Eclipse Genie CLA 2020-08-26 17:38:16 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/egit/egit/+/168287
Comment 4 Lars Vogel CLA 2020-08-27 10:59:23 EDT 
Created attachment 283978 [details]
Screenshot

Way better, thanks Thomas. The remote branches still look too light.
Comment 5 Thomas Wolf CLA 2020-08-27 13:52:15 EDT 
Looks fine IMO, but we can darken those, too. Do you want all these colors be muted/darkened, or just the one for remote branches? (Tags and annotated tags?)
Comment 6 Lars Vogel CLA 2020-08-27 14:40:14 EDT 
(In reply to Thomas Wolf from comment #5)
> Looks fine IMO, but we can darken those, too. Do you want all these colors
> be muted/darkened, or just the one for remote branches? (Tags and annotated
> tags?)

All would be the best IMHO
Comment 7 Lars Vogel CLA 2020-08-27 14:41:10 EDT 
(In reply to Thomas Wolf from comment #5)
> Looks fine IMO, but we can darken those, too. Do you want all these colors
> be muted/darkened, or just the one for remote branches? (Tags and annotated
> tags?)

The green colour (master) looks already dark enough IMHO