Bug 540466 - Stashing files: Check "Include untracked files" by default
Summary: Stashing files: Check "Include untracked files" by default
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 10
: P3 enhancement with 2 votes (vote)
Target Milestone: 5.6   Edit
Assignee: Jonas Hungershausen CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-25 09:16 EDT by Steffen Brüntjen CLA
Modified: 2019-10-16 09:05 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Brüntjen CLA 2018-10-25 09:16:22 EDT
When implementing a new feature, the normal workflow typically includes creation of new source files. Now git stash helps to quickly switch between branches by suspending and resuming the current work. The most normal use case (100% for me) is to stash all files, including untracked files. (Permanently untracked files should be in a .gitignore definition anyway because you don't want to handle them in every commit.)

I've been missing to tick that checkbox a hundred times. Would it be possible to check "Include untracked files" in the "Commit Stash" window by default or to make it configurable?
Comment 1 Jonas Hungershausen CLA 2018-10-28 15:11:23 EDT
I too am facing this problem multiple times a week. Would be nice to have it checked by default.
Comment 2 Pierre-Yves Bigourdan CLA 2019-08-29 04:52:38 EDT
+1, the default should be changed in my opinion as well!
Comment 3 Eclipse Genie CLA 2019-10-13 10:08:40 EDT
New Gerrit change created: https://git.eclipse.org/r/151015
Comment 4 Michael Keppler CLA 2019-10-14 08:15:48 EDT
While I'm fine with the suggestion, there is yet an alternative: Leave the default unchecked for new installations, but remember the checkbox value in the preferences and use the same as last time (if the preference value exists).

That would lead to the user needing to check it one time on purpose (and would therefore avoid surprises for existing users) and then have it checked all the time.

Just to be clear: I do not suggest a new visible git preference on the preference pages, just storing the value in the preference store.
Comment 5 Jonas Hungershausen CLA 2019-10-14 15:15:38 EDT
I amended the current change set with the preference based solution. Please let me know if there is anything I missed.
Comment 6 Eclipse Genie CLA 2019-10-16 08:56:15 EDT
Gerrit change https://git.eclipse.org/r/151015 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=0756f4d648f24ef07e4c3ad0230dbb332ec26308