Bug 541500 - JGit should support config option "http.userAgent" and "http.extraHeader"
Summary: JGit should support config option "http.userAgent" and "http.extraHeader"
Status: RESOLVED FIXED
Alias: None
Product: JGit
Classification: Technology
Component: JGit (show other bugs)
Version: 5.2   Edit
Hardware: PC Mac OS X
: P3 enhancement (vote)
Target Milestone: 5.10   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-23 08:05 EST by Konrad Windszus CLA
Modified: 2020-09-27 04:57 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konrad Windszus CLA 2018-11-23 08:05:09 EST 
Both options described in https://git-scm.com/docs/git-config#git-config-httpextraHeader and https://git-scm.com/docs/git-config#git-config-httpuserAgent should be supported by JGit.
Comment 1 Eclipse Genie CLA 2018-11-23 08:40:25 EST 
New Gerrit change created: https://git.eclipse.org/r/132970
Comment 2 James Wynn CLA 2020-08-03 14:21:40 EDT 
This functionality is becoming more common. Any reason why this was abandoned?
Comment 3 Thomas Wolf CLA 2020-08-04 19:27:41 EDT 
None in particular as far as I see. There were no tests and no follow-up. There was a question whether it was correct to include those extra headers also on redirects, but apparently that's what curl (and thus git) also does, so that bit would fine from my point of view.
Comment 4 James Wynn CLA 2020-08-20 09:53:18 EDT 
I've update this patch to work on the current master and I've addressed the issues from the original code review. Would it be best to create a new code review?
Comment 5 Matthias Sohn CLA 2020-08-20 12:07:46 EDT 
(In reply to James Wynn from comment #4)
> I've update this patch to work on the current master and I've addressed the
> issues from the original code review. Would it be best to create a new code
> review?

try to push it as a new patchset of the existing change, if your permissions don't allow this you can push it as a new change and add a comment on the old change referring to the new one
Comment 6 James Wynn CLA 2020-09-18 09:37:28 EDT 
What can I do to help this get merged?
Comment 7 Thomas Wolf CLA 2020-09-27 04:57:35 EDT 
Doing the Genie's job: https://git.eclipse.org/c/jgit/jgit.git/commit/?id=2171f868d95f110024e90de635627f14a3fb4700 was merged to master.