Bug 545240 - [repoView] allow inverse tags sort order
Summary: [repoView] allow inverse tags sort order
Status: CLOSED WONTFIX
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-09 14:41 EST by Alexander Nittka CLA
Modified: 2020-04-21 17:30 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Nittka CLA 2019-03-09 14:41:42 EST
Bug 442238 dealt with sorting tags better than lexicographically. This is a spin-off of Bug 540003 where inverse sorting was suggested.

Usually the latest tags will be of interest and if there are many tags those are at the very end of the Tags-subtree. Being able to invert (and maybe prune) the list of tags might improve readability.

The alternative sorting could be implemented using a sortOnly navigatorContent or a flag interpreted by the existing sorter. The pruning (show only the last x tags) is a more debatable feature. I want to at least mention it for discussion. You can control how many local branches there are, which remote branches you track, but currently you are helpless when it comes to repositories with dozens of branches...
Comment 1 Matthias Sohn CLA 2019-03-09 16:45:14 EST
+1 for sorting tags descending so that the highest version is at the top
I think this should be the default since the most recent releases are typically the ones which are most interesting
Comment 2 Eclipse Genie CLA 2019-03-10 06:56:10 EDT
New Gerrit change created: https://git.eclipse.org/r/138435
Comment 3 Eclipse Genie CLA 2019-03-10 07:18:37 EDT
New Gerrit change created: https://git.eclipse.org/r/138436
Comment 4 Alexander Nittka CLA 2019-03-11 15:14:43 EDT
One review comment in https://git.eclipse.org/r/#/c/138436/ raises the question whether to use the same sorting order in all places where a list of tags is shown. The suggestion is to store the toggle state as preference value without actually showing it on the preference page.
I guess, there is a strong argument for consistency - sorting the same way everywhere. I'll have to do more example digging in order to do the implementation...

(If you don't like the new sorting default, it is quite easy to restore, but without having the entry in the preference view, you can't use Oomph's preference recorder. You'd have to know the ID to write the preference task by hand.)
Comment 5 Alexander Nittka CLA 2019-03-24 02:33:20 EDT
I am inclined to withdraw the request/proposed change. An overall consistent sorting seems to involve enormous work as in some cases the type of the sorted string (tag/branch etc.) is not is not available to the comparator.

A best effort apporach is started in patch 3 of https://git.eclipse.org/r/138436
Comment 6 Eclipse Genie CLA 2020-03-29 13:38:55 EDT
New Gerrit change created: https://git.eclipse.org/r/160160
Comment 7 Eclipse Genie CLA 2020-04-03 11:03:15 EDT
Gerrit change https://git.eclipse.org/r/160160 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=65f373e635f306b4f7979d0c400883f6c7b6d616
Comment 8 Thomas Wolf CLA 2020-04-03 11:05:53 EDT
Tag filtering is in. Alexander, can we close this?
Comment 9 Alexander Nittka CLA 2020-04-04 01:35:16 EDT
Yes. With the option of filtering tags, changing the sort order becomes obsolete - at least for me. So no change required.
Comment 10 Eclipse Genie CLA 2020-04-21 17:30:07 EDT
Gerrit change https://git.eclipse.org/r/160532 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=d081df162a972af1b570f8eae6e99343988d5c2d