Bug 551024 - NPE in BranchOperationUI
Summary: NPE in BranchOperationUI
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 5.5   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: 5.6   Edit
Assignee: Michael Keppler CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-12 11:59 EDT by Michael Keppler CLA
Modified: 2019-09-17 16:12 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Keppler CLA 2019-09-12 11:59:20 EDT
java.lang.NullPointerException
	at org.eclipse.egit.ui.internal.branch.BranchOperationUI$CheckoutJob.run(BranchOperationUI.java:275)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)


Reproduction (not always):
* select a branch node
* hit Del, hit Enter

I sometimes run into this when I want to immediately close the "branches not merged" dialog, but there is no such dialog. In that case egit tries to checkout the branch which is deleted at the same time. We should avoid the NPE, even though is basically a user error.
Comment 1 Eclipse Genie CLA 2019-09-12 12:05:56 EDT
New Gerrit change created: https://git.eclipse.org/r/149435
Comment 2 Eclipse Genie CLA 2019-09-17 16:11:44 EDT
Gerrit change https://git.eclipse.org/r/149435 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=4edc693712f7fc221c9d102182f1eb2afb64c962