Bug 551578 - cancel file diff viewer job when scheduling next one
Summary: cancel file diff viewer job when scheduling next one
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 5.6   Edit
Hardware: PC Windows 10
: P3 enhancement (vote)
Target Milestone: 5.6   Edit
Assignee: Michael Keppler CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-27 18:06 EDT by Michael Keppler CLA
Modified: 2019-10-01 04:26 EDT (History)
0 users

See Also:

Attachments
screenshot (34.68 KB, image/png)
2019-09-27 18:06 EDT, Michael Keppler CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Keppler CLA 2019-09-27 18:06:27 EDT 
Created attachment 280078 [details]
screenshot

When scrolling fast through history, I see this in the progress view
* exactly 1 "building commit info", independent of how long it takes
* several pages of "updating file differences". the longer I scroll, the more (up to a certain limit)

To me it seems like one of the jobs is not cancelled when scheduling its next instance. I'm not even sure if cancelling the job would actually make a difference for the git work being done inside the job, but we could at least avoid the widget updates when we check for the cancel state inside the job.
Comment 1 Michael Keppler CLA 2019-09-27 18:09:54 EDT 
Side note: The file diff job also seems to be missing a job family from the egit predefined families, since it does not show any of the egit specific icons in the progress monitor.
Comment 2 Eclipse Genie CLA 2019-09-28 01:25:52 EDT 
New Gerrit change created: https://git.eclipse.org/r/150290
Comment 3 Eclipse Genie CLA 2019-10-01 04:25:02 EDT 
Gerrit change https://git.eclipse.org/r/150290 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=072c3c64a87e3316c2bfb616573261ec4c52ce2b