Community
Participate
Working Groups
This text is currently centered. I think that looks strange, especially if the dialog is made smaller.
New Gerrit change created: https://git.eclipse.org/r/152609
Created attachment 280649 [details] ref filters before change on windows
Created attachment 280650 [details] ref filters as in patchset 1 on windows
I completely like the fix of the centered label, but there are quite some side effects in the layout from your changes. I've marked everything that does not look right to me, without distinguishing between what's new in your change and what was there before. If you like, I could give this a try on Windows and have you check the result on your Mac(?). But it might take until the weekend.
(In reply to Michael Keppler from comment #4) > I completely like the fix of the centered label, but there are quite some > side effects in the layout from your changes. I've marked everything that > does not look right to me, without distinguishing between what's new in your > change and what was there before. > > If you like, I could give this a try on Windows and have you check the > result on your Mac(?). But it might take until the weekend. Yes, that doesn't look good. Surprising that we get such platform differences. Images for how it looks on Mac are in the EGit N&N: https://wiki.eclipse.org/File:EGit_RefFilter_Config_Default.png Before state is the first upload, after state the second one. (Wiki currently seems to have problems. Can't connect.)
Seems to have come back. So for images from Mac: * Before: https://wiki.eclipse.org/images/archive/3/35/20191113215215%21EGit_RefFilter_Config_Default.png * After: https://wiki.eclipse.org/images/3/35/EGit_RefFilter_Config_Default.png
(In reply to Michael Keppler from comment #4) > If you like, I could give this a try on Windows and have you check the > result on your Mac(?). But it might take until the weekend. I didn't expect platform differences for these changes at all! On Windows it apparently looked fine. I'll split this: reduce the existing commit to only the label alignment. Then I'll give the other alignment problems another shot on Mac. Makes IMO not much sense if you try it on Windows; since it already looked good there, you'd be working in the dark.
New Gerrit change created: https://git.eclipse.org/r/152694
Gerrit change https://git.eclipse.org/r/152694 was merged to [master]. Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=fc23d9333a951b7f1c66594496ed6737c04b08a5
Label not centered anymore. For the rest, I may open a new issue if and when I get around to try again.