NEW DATE! Bugzilla will undergo maintenance 2024-03-28 18h00 CET. Bugzilla will be placed in read-only mode at that time.

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 552971 - Left align explanatory text in GitHistoryRefFilterConfigurationDialog
Summary: Left align explanatory text in GitHistoryRefFilterConfigurationDialog
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 5.6   Edit
Hardware: PC All
: P3 trivial (vote)
Target Milestone: 5.6   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-12 13:57 EST by Thomas Wolf CLA
Modified: 2019-11-15 03:48 EST (History)
1 user (show)

See Also:


Attachments
ref filters before change on windows (28.60 KB, image/png)
2019-11-14 12:53 EST, Michael Keppler CLA
no flags Details
ref filters as in patchset 1 on windows (31.60 KB, image/png)
2019-11-14 12:53 EST, Michael Keppler CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Wolf CLA 2019-11-12 13:57:08 EST
This text is currently centered. I think that looks strange, especially if the dialog is made smaller.
Comment 1 Eclipse Genie CLA 2019-11-13 15:06:46 EST
New Gerrit change created: https://git.eclipse.org/r/152609
Comment 2 Michael Keppler CLA 2019-11-14 12:53:04 EST
Created attachment 280649 [details]
ref filters before change on windows
Comment 3 Michael Keppler CLA 2019-11-14 12:53:44 EST
Created attachment 280650 [details]
ref filters as in patchset 1 on windows
Comment 4 Michael Keppler CLA 2019-11-14 13:31:18 EST
I completely like the fix of the centered label, but there are quite some side effects in the layout from your changes. I've marked everything that does not look right to me, without distinguishing between what's new in your change and what was there before.

If you like, I could give this a try on Windows and have you check the result on your Mac(?). But it might take until the weekend.
Comment 5 Thomas Wolf CLA 2019-11-14 14:24:13 EST
(In reply to Michael Keppler from comment #4)
> I completely like the fix of the centered label, but there are quite some
> side effects in the layout from your changes. I've marked everything that
> does not look right to me, without distinguishing between what's new in your
> change and what was there before.
> 
> If you like, I could give this a try on Windows and have you check the
> result on your Mac(?). But it might take until the weekend.

Yes, that doesn't look good. Surprising that we get such platform differences. Images for how it looks on Mac are in the EGit N&N:

https://wiki.eclipse.org/File:EGit_RefFilter_Config_Default.png

Before state is the first upload, after state the second one.

(Wiki currently seems to have problems. Can't connect.)
Comment 7 Thomas Wolf CLA 2019-11-14 15:10:29 EST
(In reply to Michael Keppler from comment #4)
> If you like, I could give this a try on Windows and have you check the
> result on your Mac(?). But it might take until the weekend.

I didn't expect platform differences for these changes at all! On Windows it apparently looked fine.

I'll split this: reduce the existing commit to only the label alignment. Then I'll give the other alignment problems another shot on Mac. Makes IMO not much sense if you try it on Windows; since it already looked good there, you'd be working in the dark.
Comment 8 Eclipse Genie CLA 2019-11-14 15:38:42 EST
New Gerrit change created: https://git.eclipse.org/r/152694
Comment 9 Eclipse Genie CLA 2019-11-15 02:35:43 EST
Gerrit change https://git.eclipse.org/r/152694 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=fc23d9333a951b7f1c66594496ed6737c04b08a5
Comment 10 Thomas Wolf CLA 2019-11-15 03:48:24 EST
Label not centered anymore. For the rest, I may open a new issue if and when I get around to try again.