Bug 553053 - Always show "(X/Y)" when filtering is active in staging view
Summary: Always show "(X/Y)" when filtering is active in staging view
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 5.6   Edit
Hardware: PC Windows 10
: P3 enhancement (vote)
Target Milestone: 5.8   Edit
Assignee: Michael Keppler CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-14 09:27 EST by Michael Keppler CLA
Modified: 2020-06-15 14:15 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Keppler CLA 2019-11-14 09:27:53 EST
Have some files in staging view.
Enable filter bar.
Write a filter expression that matches all staging entries.

Result: It is not immediately clear whether the filter has been applied or the system is still working. In case all entries match the filter, we only show "Unstaged Changes (123)" instead of "Unstaged Changes (123/123)".

I suggest to always show both numbers when a filter string is used, even if the filter matches all staging entries.


Independent of this, I'm also wondering if "x of y" would be more appropriate than "x/y".
Comment 1 Eclipse Genie CLA 2019-11-22 08:40:34 EST
New Gerrit change created: https://git.eclipse.org/r/153190
Comment 2 Eclipse Genie CLA 2020-06-06 16:15:48 EDT
Gerrit change https://git.eclipse.org/r/153190 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=e638d18d4ee5ca0f60a76eb3e0095b1218a87779