Bug 553072 - [history] ref filter dialog: use ${variable} syntax of eclipse
Summary: [history] ref filter dialog: use ${variable} syntax of eclipse
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 5.6   Edit
Hardware: PC Windows 10
: P3 enhancement (vote)
Target Milestone: 5.6   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-14 13:30 EST by Michael Keppler CLA
Modified: 2019-11-23 13:30 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Keppler CLA 2019-11-14 13:30:21 EST 
The macro in the ref filter dialog is currently implemented by matching "[CURRENT-BRANCH]". I like things unified, therefore I would rather use "${git_branch}", which is already available at other places in eclipse, where variables can be used.

If someone feels it should be current_branch instead of git_branch, that's fine to me. But please let's use the "${ }" syntax.
Comment 1 Thomas Wolf CLA 2019-11-14 14:49:57 EST 
+1 for both
Comment 2 Thomas Wolf CLA 2019-11-18 05:14:24 EST 
One problem with "${git_branch}" is that it's a valid branch name...
Comment 3 Andrey Loskutov CLA 2019-11-18 10:16:38 EST 
(In reply to Thomas Wolf from comment #2)
> One problem with "${git_branch}" is that it's a valid branch name...

I wouldn't care about that. Whoever uses such names is $....t.
Comment 4 Eclipse Genie CLA 2019-11-23 11:35:39 EST 
New Gerrit change created: https://git.eclipse.org/r/153261
Comment 5 Eclipse Genie CLA 2019-11-23 13:07:11 EST 
Gerrit change https://git.eclipse.org/r/153261 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=1009fc591d26f3eb824d7c42edaefa9d9799cf72