Community
Participate
Working Groups
In the history view menu, add a separator * after the first menu item (invoking the dialog) * after the last preconfigured filter menu item It would be icing on the cake to have a new icon for the first menu item (funnel with little branch overlay), but I'm not the graphics guru for that. In the history view menu and in the dialog, rework the suffix for preconfigured filters. "- (preconfigured)" is somewhat double. Either hyphen or braces seem sufficient to me. I suggest " (predefined)" instead (notice the changed wording and the removed hyphen).
New Gerrit change created: https://git.eclipse.org/r/153264
Gerrit change https://git.eclipse.org/r/153264 was merged to [master]. Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=1b6c1c646276d3a7762604b3a691de023630a3e5
Hadn't you planned to also change " - (preconfigured)" to " (predefined)"?
(In reply to Thomas Wolf from comment #3) > Hadn't you planned to also change " - (preconfigured)" to " (predefined)"? Yes, as you also noticed by my mixed commit in another change. However, when trying it out, I didn't feel that it really improved readability, so I decided against that change. I still believe that hyphen and braces is somewhat double, but I have no better ideas right now. If I were good in icon creation, maybe I would try to use 2 different icons for the 2 sets of filters, but I'm not.