NEW DATE! Bugzilla will undergo maintenance 2024-03-28 18h00 CET. Bugzilla will be placed in read-only mode at that time.

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 553093 - [history] Improve distinction between preconfigured and user ref filters
Summary: [history] Improve distinction between preconfigured and user ref filters
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 5.6   Edit
Hardware: PC Windows 10
: P3 enhancement (vote)
Target Milestone: 5.6   Edit
Assignee: Michael Keppler CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-15 03:02 EST by Michael Keppler CLA
Modified: 2019-11-25 14:38 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Keppler CLA 2019-11-15 03:02:17 EST
In the history view menu, add a separator
* after the first menu item (invoking the dialog)
* after the last preconfigured filter menu item

It would be icing on the cake to have a new icon for the first menu item (funnel with little branch overlay), but I'm not the graphics guru for that.

In the history view menu and in the dialog, rework the suffix for preconfigured filters. "- (preconfigured)" is somewhat double. Either hyphen or braces seem sufficient to me. I suggest " (predefined)" instead (notice the changed wording and the removed hyphen).
Comment 1 Eclipse Genie CLA 2019-11-23 13:06:00 EST
New Gerrit change created: https://git.eclipse.org/r/153264
Comment 2 Eclipse Genie CLA 2019-11-24 11:36:40 EST
Gerrit change https://git.eclipse.org/r/153264 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=1b6c1c646276d3a7762604b3a691de023630a3e5
Comment 3 Thomas Wolf CLA 2019-11-24 12:39:41 EST
Hadn't you planned to also change " - (preconfigured)" to " (predefined)"?
Comment 4 Michael Keppler CLA 2019-11-25 14:38:20 EST
(In reply to Thomas Wolf from comment #3)
> Hadn't you planned to also change " - (preconfigured)" to " (predefined)"?

Yes, as you also noticed by my mixed commit in another change. However, when trying it out, I didn't feel that it really improved readability, so I decided against that change.

I still believe that hyphen and braces is somewhat double, but I have no better ideas right now. If I were good in icon creation, maybe I would try to use 2 different icons for the 2 sets of filters, but I'm not.