Bug 553188 - Repository group deletion confirmation disabled automatically
Summary: Repository group deletion confirmation disabled automatically
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 5.6   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: 5.6   Edit
Assignee: Thomas Wolf CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-18 13:44 EST by Michael Keppler CLA
Modified: 2019-11-20 13:07 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Keppler CLA 2019-11-18 13:44:21 EST 
After a repo group has been deleted once, the confirmation will not appear again, although the checkbox has not been checked. Looking at the git preferences afterwards its also unchecked there, so some code magically clears the flag.
Comment 1 Eclipse Genie CLA 2019-11-18 14:16:08 EST 
New Gerrit change created: https://git.eclipse.org/r/152895
Comment 2 Thomas Wolf CLA 2019-11-18 14:16:55 EST 
Cannot reproduce as stated, but the flag was also set to false when the dialog was canceled. That's fixed by https://git.eclipse.org/r/152895 .
Comment 3 Eclipse Genie CLA 2019-11-20 04:33:20 EST 
Gerrit change https://git.eclipse.org/r/152895 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=6665fde1e3056c69aa5a1dd9d4e17ac578890b03
Comment 4 Thomas Wolf CLA 2019-11-20 05:06:47 EST 
Can this be closed, or is there indeed still a problem with that flag?
Comment 5 Michael Keppler CLA 2019-11-20 13:07:45 EST 
You are right, this can be closed. I also only had the use case of cancelling the dialog.