Description Thomas Wolf 2019-11-20 05:41:59 EST

Probably always been the case. However, previously the choices were "Show All" and "Show history from HEAD", so one always had a useful history.

Newly, the filters set in the history view perhaps make no sense at all for this dialog. (Just try disabling all filters: the git history will be empty, but so will the CommitSelectionDialog.)

Moreover, in the CommitSelectionDialog, the title mentions how many commit there are: "N commits in repository foo". But this is misleading; it's just the number of commits in the filtered list shown.

- The title message needs to be improved.
- The dialog needs to get a little toolbar with the same "Select branches to show"/"First-parent-only" buttons as in the history view.
- It must be possible to have different sets of settings, one for that dialog, and one for the history view. (If there are no dialog-specific settings, the ones from the history view shall be taken by default.)
- There needs to be an explanatory message to tell the user to change the filters if he doesn't see the commit he's looking for (and it's not already set to show all). Especially if the list shows zero commits, but the repo does have commits.

I also question whether it makes sense to be able to de-select the HEAD filter at all. Perhaps at least the dialog should always forcibly include HEAD.