Bug 553428 - Message for post commit hook is misleading
Summary: Message for post commit hook is misleading
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 5.11   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-25 10:22 EST by Tim Neumann CLA
Modified: 2021-02-15 17:02 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Neumann CLA 2019-11-25 10:22:42 EST
When the git post commit hook exits with a non-zero exit code EGIT shows a popup containing predefined text and the output of the hook.

The predefined text (and title of the popup) suggests that the commit was aborted/rejected even though the post-commit hook cannot do this.

The title is: 'Commit was aborted by hook'
The text is: 'Rejected by "post-commit" hook.'
Comment 1 Eclipse Genie CLA 2019-12-13 09:20:22 EST
New Gerrit change created: https://git.eclipse.org/r/154476
Comment 2 Fabian Pfaff CLA 2020-05-23 08:55:34 EDT
I ran into the same issue last night and got confused by the misleading error message.

Tim Neumann: Do you plan on finishing your Gerrit change? Do you currently don't have the time?
Comment 3 Andrey Loskutov CLA 2020-05-26 10:50:38 EDT
(In reply to Fabian Pfaff from comment #2)
> Tim Neumann: Do you plan on finishing your Gerrit change? Do you currently
> don't have the time?

Tim is not working on Eclipse anymore, so feel free to update the patch.
Comment 4 Fabian Pfaff CLA 2020-09-14 03:08:55 EDT
I've addressed the comments and rebased the changeset.