Bug 553471 - Show output of hooks even if they don't fail
Summary: Show output of hooks even if they don't fail
Status: NEW
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 580910
  Show dependency tree
 
Reported: 2019-11-26 05:05 EST by Tim Neumann CLA
Modified: 2022-10-14 06:09 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Neumann CLA 2019-11-26 05:05:44 EST 
Currently the only time EGIT shows the user an output of a git hook is when the hook fails (exitst non-zero), which also causes e.g. the commit to abort.
This also only shows stderr.

But some hooks may want to inform/warn the user about something without aborting.

Therefore it would be nice if egit would be able to create a popup with the stdout of the hook if there is any. 

I guess this should be able to be disabled in the preferences. (or maybe even disabled by default)
Comment 1 Tim Neumann CLA 2019-11-26 05:14:39 EST 
For compatability with as many hooks as possible this info/warning popup should show stdout AND stderr
Comment 2 Tim Neumann CLA 2019-11-26 05:15:38 EST 
When the hook fails the info/warning should not be shown as a seperate popup, but included in the already existing popup.
Comment 3 Thomas Wolf CLA 2019-11-26 07:51:24 EST 
See also bug 536659 and bug 549246.
Comment 4 Matthias Sohn CLA 2019-11-26 09:37:57 EST 
popups should be non-modal
Comment 5 Eclipse Genie CLA 2019-11-28 10:01:05 EST 
New Gerrit change created: https://git.eclipse.org/r/153536
Comment 6 Eclipse Genie CLA 2019-11-28 10:01:08 EST 
New Gerrit change created: https://git.eclipse.org/r/153537
Comment 7 Eclipse Genie CLA 2019-12-08 19:57:13 EST 
Gerrit change https://git.eclipse.org/r/153536 was merged to [stable-5.6].
Commit: http://git.eclipse.org/c/jgit/jgit.git/commit/?id=23125abc20758f06aae9877306ceca6651750b3c