Description Thomas Wolf 2019-12-05 15:43:49 EST

The setup of the lightweight decorator in the git repositories view (and in RepositoryTreeNodeLabelProvider) is not correct; it doesn't work well with the CNF. We've managed to hide the problems mostly by doing our own caching of text decorations, but we have to compute images including their decorations in the label provider on the UI thread instead of doing image decorations in the background decorator. Also, the current setup is too specific for our own decorator and doesn't account for the gitflow decorator. (The gitflow icon overlay on repositories is thus never shown; if it were enabled, it'd blink on refreshes.)

This needs to be fixed and restructured such that the whole setup is more in line with the usual ways. Image decorations should occur in the background decorator, and there should be no blinking. A special problem will be the directories of repositories and working trees shown *after* the decorator.