Bug 560438 - Cannot install 5.6.1.202002131546-r
Summary: Cannot install 5.6.1.202002131546-r
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: Releng (show other bugs)
Version: 5.6   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 5.7   Edit
Assignee: Thomas Wolf CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-23 10:39 EST by Sebastian Zarnekow CLA
Modified: 2020-04-18 11:18 EDT (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Zarnekow CLA 2020-02-23 10:39:14 EST
When using the update site https://download.eclipse.org/egit/updates I get 

ERROR: org.eclipse.equinox.p2.director code=0 Software being installed: artificial_root 1.0.0.v1582464824656
  ERROR: org.eclipse.equinox.p2.director code=0 Missing requirement: Apache HttpClient 4.5.6.v20190503-0009 (org.apache.httpcomponents.httpclient 4.5.6.v20190503-0009) requires 'java.package; org.apache.commons.codec.binary [1.10.0,1.11.0)' but it could not be found
  ERROR: org.eclipse.equinox.p2.director code=1 Cannot satisfy dependency:
    ERROR: org.eclipse.equinox.p2.director code=0 From: artificial_root 1.0.0.v1582464824656
    ERROR: org.eclipse.equinox.p2.director code=0 To: org.eclipse.equinox.p2.iu; org.eclipse.egit.feature.group 0.0.0
  ERROR: org.eclipse.equinox.p2.director code=1 Cannot satisfy dependency:
    ERROR: org.eclipse.equinox.p2.director code=0 From: Git integration for Eclipse 5.6.1.202002131546-r (org.eclipse.egit.feature.group 5.6.1.202002131546-r)
    ERROR: org.eclipse.equinox.p2.director code=0 To: org.eclipse.equinox.p2.iu; org.eclipse.jgit.http.apache.feature.group [5.6.1,5.7.0)
  ERROR: org.eclipse.equinox.p2.director code=1 Cannot satisfy dependency:
    ERROR: org.eclipse.equinox.p2.director code=0 From: Java implementation of Git - optional Http support using Apache httpclient 5.6.1.202002131546-r (org.eclipse.jgit.http.apache.feature.group 5.6.1.202002131546-r)
    ERROR: org.eclipse.equinox.p2.director code=0 To: org.eclipse.equinox.p2.iu; org.apache.httpcomponents.httpclient [4.5.6.v20190503-0009,4.5.6.v20190503-0009]
Comment 1 Andrey Loskutov CLA 2020-02-23 11:00:23 EST
I assume you are using Eclipse 4.15 M3? With that you should use EGit 4.7. It is mostly same problem like in bug 559925, just other way around.
Comment 2 Thomas Wolf CLA 2020-02-23 11:37:42 EST
EGit 5.7 (i.e., nightly), not 4.7.

JGit didn't include all the transitive dependencies for org.apache.httpsomponents in its own repo before 5.7, but relied on either platform having them or some Orbit update site being configured.

Now platform has moved to newer httpcomponents than specified in JGit 5.6, JGit 5.6.x lacks org.apache.commons.code 1.10.

Add https://download.eclipse.org/tools/orbit/downloads/drops/R20191126223242/repository as an update site, and have "Contact all update sites" checked when trying to install EGit 5.6.x.

EGit 5.7 does include the commons.codec version needed by the httpcomponent bundles included, so there should be no problem with that also when installed in older Eclipses. Additionally, the EGit 5.7 update site now links to the Orbit update site it uses.

Sorry for the mess.

@Andrey: I suppose bug 559925 can be closed? EGit 5.7 should install properly in any Eclipse version, with "Contact all update sites" off.
Comment 3 Christian Dietrich CLA 2020-02-23 11:39:09 EST
Is there an eta for the 5.7 release?
Comment 4 Thomas Wolf CLA 2020-02-23 11:39:42 EST
(In reply to Thomas Wolf from comment #2)
> org.apache.httpsomponents
httpcomponents, of course
> org.apache.commons.code 1.10.
commons.codec, I meant.
Comment 5 Thomas Wolf CLA 2020-02-23 11:40:50 EST
(In reply to Christian Dietrich from comment #3)
> Is there an eta for the 5.7 release?
Of course. SimRel 2020-03: March 18, 2020.
Comment 6 Andrey Loskutov CLA 2020-02-23 11:46:07 EST
(In reply to Thomas Wolf from comment #2)
> EGit 5.7 (i.e., nightly), not 4.7.
sure

> @Andrey: I suppose bug 559925 can be closed? EGit 5.7 should install
> properly in any Eclipse version, with "Contact all update sites" off.

The problem that PDE shows "missing" packages error on startup, while they are present, is still in the PDE, see bug 559925 comment 7. So all pre-4.15 target platforms with 5.7+ Egit included are still affected.
Comment 7 Christian Dietrich CLA 2020-02-23 12:15:19 EST
i can confirm that using the nightly update site seems to solve the issue
Comment 8 Thomas Wolf CLA 2020-02-24 02:34:54 EST
(In reply to Andrey Loskutov from comment #6)
> So all pre-4.15 target platforms with 5.7+ Egit included are still affected.

EGit 5.7.0 installs without problems in RSA 9.7.0.x (which is an Eclipse Oxygen), and also in STS 4.5.1 (which is a 4.14), and both products run without problems afterwards. So I don't know what that PDE problem is.
Comment 9 Andrey Loskutov CLA 2020-02-24 02:40:20 EST
(In reply to Thomas Wolf from comment #8)
> EGit 5.7.0 installs without problems in RSA 9.7.0.x (which is an Eclipse
> Oxygen), and also in STS 4.5.1 (which is a 4.14), and both products run
> without problems afterwards. So I don't know what that PDE problem is.

See bug 559925 comment 7. Try to run Eclipse from Eclipse on such target platform, you will see PDE error.
Comment 10 Thomas Wolf CLA 2020-02-24 02:46:20 EST
(In reply to Andrey Loskutov from comment #9)
> (In reply to Thomas Wolf from comment #8)
> > EGit 5.7.0 installs without problems in RSA 9.7.0.x (which is an Eclipse
> > Oxygen), and also in STS 4.5.1 (which is a 4.14), and both products run
> > without problems afterwards. So I don't know what that PDE problem is.
> 
> See bug 559925 comment 7. Try to run Eclipse from Eclipse on such target
> platform, you will see PDE error.

I run EGit master all the time against our the egit-4.6 (Neon) target in a child Eclipse; no problem there.
Comment 11 Eclipse Genie CLA 2020-02-24 03:45:11 EST
New Gerrit change created: https://git.eclipse.org/r/158201
Comment 12 Thomas Wolf CLA 2020-02-24 03:57:30 EST
(In reply to Eclipse Genie from comment #11)
> New Gerrit change created: https://git.eclipse.org/r/158201

That change adds a reference in the EGit 5.6 update site to the Orbit p2 repo used for that version (R20191126223242). That at least should ensure that the commons.codec 1.10 bundle should be found. I don't know whether that is sufficient to make EGit 5.6.2 install properly on a 4.15 platform; that "substitutable export" mentioned in bug 559925 worries me a bit. See bug 559925 comment 9.
Comment 13 Eclipse Genie CLA 2020-02-24 14:56:22 EST
Gerrit change https://git.eclipse.org/r/158201 was merged to [stable-5.6].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=c08f7ca210cacb5728c9e0fad10e5b402b7516e9
Comment 14 Andrey Loskutov CLA 2020-02-24 15:43:07 EST
(In reply to Thomas Wolf from comment #10)
>  platform, you will see PDE error.
> 
> I run EGit master all the time against our the egit-4.6 (Neon) target in a
> child Eclipse; no problem there.

Interesting, with 4.12 platform we see an error. Most likely Neon has an older http... crap that doesn't have that recursive package import nightmare.
Comment 15 Michael Keppler CLA 2020-04-18 10:55:27 EDT
The original problem should be fixed (assuming Christian tested the same scenario as Sebastian).

@Andrey: Is there still an open issue from your side regarding the Neon target compatibility? Or can we close the bug?
Comment 16 Andrey Loskutov CLA 2020-04-18 11:08:30 EDT
(In reply to Michael Keppler from comment #15)
> The original problem should be fixed (assuming Christian tested the same
> scenario as Sebastian).
> 
> @Andrey: Is there still an open issue from your side regarding the Neon
> target compatibility? Or can we close the bug?

We've patched 5.7.0 egit for our 4.12 platform, so that it doesn't conflict with it. For 4.15 we don't have problems AFAIK.