Bug 560527 - Expose FileStoreAttributes.setBackground to other callers
Summary: Expose FileStoreAttributes.setBackground to other callers
Status: RESOLVED FIXED
Alias: None
Product: JGit
Classification: Technology
Component: JGit (show other bugs)
Version: 5.7   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 5.6.2   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 560412
  Show dependency tree
 
Reported: 2020-02-25 16:14 EST by Alex Blewitt CLA
Modified: 2020-03-04 16:08 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Blewitt CLA 2020-02-25 16:14:37 EST 
If we expose FileStoreAttributes.setBackground to others, they can call it directly without needing to load a number of JGit classes.
Comment 1 Eclipse Genie CLA 2020-02-25 16:30:49 EST 
New Gerrit change created: https://git.eclipse.org/r/158353
Comment 2 Eclipse Genie CLA 2020-02-25 16:33:01 EST 
New Gerrit change created: https://git.eclipse.org/r/158354
Comment 3 Alex Blewitt CLA 2020-02-25 16:34:14 EST 
Not sure if you want to have this targetted against stable-5.6 or master (will need rebasing on master if so)
Comment 4 Lars Vogel CLA 2020-02-25 16:47:30 EST 
(In reply to Alex Blewitt from comment #3)
> Not sure if you want to have this targetted against stable-5.6 or master
> (will need rebasing on master if so)

I think you should develop against master.
Comment 5 Eclipse Genie CLA 2020-02-25 16:52:26 EST 
New Gerrit change created: https://git.eclipse.org/r/158356
Comment 6 Lars Vogel CLA 2020-02-25 17:10:45 EST 
Using the build in OSGi logging:

Without this patch:

184 ms for total start time event STARTED - osgi.identity; osgi.identity="org.eclipse.egit.core"; type="osgi.bundle"; version:Version="5.7.0.qualifier"; singleton:="true" [id=124]
238 ms for total start time event STARTED - osgi.identity; osgi.identity="org.eclipse.egit.ui"; type="osgi.bundle"; version:Version="5.7.0.qualifier"; singleton:="true" [id=128]


With both patches (JGit and EGit)

157 ms for total start time event STARTED - osgi.identity; osgi.identity="org.eclipse.egit.core"; type="osgi.bundle"; version:Version="5.7.0.qualifier"; singleton:="true" [id=124]
199 ms for total start time event STARTED - osgi.identity; osgi.identity="org.eclipse.egit.ui"; type="osgi.bundle"; version:Version="5.7.0.qualifier"; singleton:="true" [id=128]


To check for yourself, in your runtime configuration select the Trace tab, enable it, select org.eclipse.osgi and select debug and debug/BundleStartTime
Comment 7 Eclipse Genie CLA 2020-03-04 10:17:49 EST 
Gerrit change https://git.eclipse.org/r/158353 was merged to [stable-5.6].
Commit: http://git.eclipse.org/c/jgit/jgit.git/commit/?id=093fbbd11e01711efc1567d6c31516a448d2a455