Bug 561078 - sshd: update to sshd-osgi 2.4.0
Summary: sshd: update to sshd-osgi 2.4.0
Status: RESOLVED FIXED
Alias: None
Product: JGit
Classification: Technology
Component: JGit (show other bugs)
Version: 5.7   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 5.8   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 561189
Blocks:
  Show dependency tree
 
Reported: 2020-03-12 17:35 EDT by Thomas Wolf CLA
Modified: 2020-03-22 06:23 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Wolf CLA 2020-03-12 17:35:21 EDT 
To pick up minor fixes done upstream and keep atop of upstream interface changes.

* CQ 21777 for sshd-osgi https://dev.eclipse.org/ipzilla/show_bug.cgi?id=21777
* CQ 21778 for sshd-sftp https://dev.eclipse.org/ipzilla/show_bug.cgi?id=21778
Comment 1 Matthias Sohn CLA 2020-03-13 06:05:27 EDT 
I guess this update targets 5.8 ?
Comment 2 Thomas Wolf CLA 2020-03-13 06:10:16 EDT 
Yes, I plan to do this early in 5.8. Prepared it already locally; changes on our side are small.
Comment 3 Thomas Wolf CLA 2020-03-17 08:04:40 EDT 
The two CQs for JGit are approved now.

@Matthias, could you create the ATO CQs, please?
Comment 4 Matthias Sohn CLA 2020-03-17 08:55:01 EDT 
(In reply to Thomas Wolf from comment #3)
> The two CQs for JGit are approved now.
> 
> @Matthias, could you create the ATO CQs, please?

done

how about sshd-putty ? See bug 548080
Comment 5 Thomas Wolf CLA 2020-03-17 09:16:11 EDT 
(In reply to Matthias Sohn from comment #4)
> how about sshd-putty ?

I'm not 100% sure we should do it. Using it would mean including a putty key parser in a global setting; see [1]. We probably shouldn't do this inside the ssh.apache library; it'd force the dependency on sshd-putty to all users. Doing it outside in jgit pgm and in EGit may be fine, though.

Do we still want to do it? (It seemed like a cool idea way back, but now I'm not so sure anymore.)

If we want to do it, then yes, we'd also need a CQ for sshd-putty 2.4.0 and I'd resurrect the two old old changes [2] and [3].

[1] https://git.eclipse.org/r/#/c/146760/1/org.eclipse.egit.core/src/org/eclipse/egit/core/internal/EGitSshdSessionFactory.java
[2] https://git.eclipse.org/r/#/c/146758/
[3] https://git.eclipse.org/r/#/c/146760/
Comment 6 Matthias Sohn CLA 2020-03-17 10:00:46 EDT 
I have no need for putty support since I am using Mac and Linux only.
Comment 7 Eclipse Genie CLA 2020-03-17 19:38:55 EDT 
New Gerrit change created: https://git.eclipse.org/r/159570
Comment 9 Eclipse Genie CLA 2020-03-19 16:31:17 EDT 
New Gerrit change created: https://git.eclipse.org/r/159742
Comment 10 Eclipse Genie CLA 2020-03-19 16:34:40 EDT 
New Gerrit change created: https://git.eclipse.org/r/159743
Comment 11 Eclipse Genie CLA 2020-03-21 21:10:37 EDT 
Gerrit change https://git.eclipse.org/r/159742 was merged to [master].
Commit: http://git.eclipse.org/c/jgit/jgit.git/commit/?id=fd3778b935c1de9fd3ae7068d71c46974741dcce
Comment 12 Eclipse Genie CLA 2020-03-22 06:21:40 EDT 
Gerrit change https://git.eclipse.org/r/159743 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=2d2f3a92f82b54b70cda6882b2e947c62179c626