Community
Participate
Working Groups
Created attachment 282196 [details] Exception Stack Trace Since upgrade to Elipse 202003 I do encounter an NPE when switching from e.g. the Java Perspective to the Git Perspective. Switching back to Eclipse 201912 resolves the issue for me.
Created attachment 282197 [details] SessionData
I cannot reproduce this problem on Mac. When exactly does the NPE occur ? Immediately when switching the perspective or at a later action ? The code throwing the NPE was introduced in 5.7 by this change https://git.eclipse.org/r/#/c/153953/5/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositoryTreeNodeLabelProvider.java @Thomas: does this ring a bell ?
It happens immediately when switching from e.g. the Java Perspective to the Git Perspective. It than also happens when being in the Git Perspective and expanding a repository. With 201912 I see Repository [master] - Path on local file system With 202003 I see Repository [master] so the dash followed by the local path is missing.
(In reply to Dirk Gfroerer from comment #3) > It happens immediately when switching from e.g. the Java Perspective to the > Git Perspective. > It than also happens when being in the Git Perspective and expanding a > repository. > > With 201912 I see > Repository [master] - Path on local file system > > With 202003 I see > Repository [master] > > so the dash followed by the local path is missing. on Mac this works fine
I'm running Red Hat Enterprise Linux Workstation release 7.7 (Maipo) with all patches applied.
(In reply to Dirk Gfroerer from comment #5) > I'm running > > Red Hat Enterprise Linux Workstation release 7.7 (Maipo) > > with all patches applied. Cannot reproduce on CentOS 7.7, Adwaita, gtk 3.22.30, X11. Tried with a 2020-03 Eclipse JEE, both Java 8u222 and AdoptOpenJDK 11.0.6+10, and also light and dark mode. However... the code in question indeed doesn't handle rangesAfter == null. I have no idea under what circumstances the viewer cell should not have any style ranges, but I suggest we just make that code check for null and not fiddle with the styles in that case.
New Gerrit change created: https://git.eclipse.org/r/159922
Gerrit change https://git.eclipse.org/r/159922 was merged to [stable-5.7]. Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=467ab6e50409e63c34e24c9f3e60fc0d662344b4
*** Bug 561597 has been marked as a duplicate of this bug. ***
(In reply to Matthias Sohn from comment #9) > *** Bug 561597 has been marked as a duplicate of this bug. *** Oof. Eclipse has a preference to switch off styled labels: Preferences->General->Appearance->Use mixed fonts and colors for labels If that is off, there are of course no styles on the label, and then one gets this NPE.
(In reply to Thomas Wolf from comment #10) > (In reply to Matthias Sohn from comment #9) > > *** Bug 561597 has been marked as a duplicate of this bug. *** > > Oof. Eclipse has a preference to switch off styled labels: > > Preferences->General->Appearance->Use mixed fonts and colors for labels > > If that is off, there are of course no styles on the label, and then one > gets this NPE. arrgh, looks like there are too many preferences
(In reply to Thomas Wolf from comment #10) > (In reply to Matthias Sohn from comment #9) > > *** Bug 561597 has been marked as a duplicate of this bug. *** > > Oof. Eclipse has a preference to switch off styled labels: > > Preferences->General->Appearance->Use mixed fonts and colors for labels > > If that is off, there are of course no styles on the label, and then one > gets this NPE. Great, that helps.
(In reply to Florian Körner from comment #12) > (In reply to Thomas Wolf from comment #10) > > (In reply to Matthias Sohn from comment #9) > > > *** Bug 561597 has been marked as a duplicate of this bug. *** > > > > Oof. Eclipse has a preference to switch off styled labels: > > > > Preferences->General->Appearance->Use mixed fonts and colors for labels > > > > If that is off, there are of course no styles on the label, and then one > > gets this NPE. > > Great, that helps. EGit nightly should have the fix for this. Update site at https://download.eclipse.org/egit/updates-nightly .
*** Bug 562425 has been marked as a duplicate of this bug. ***
Also reported in the forum at https://www.eclipse.org/forums/index.php/t/1103486/ .
