Bug 562158 - CloneOperationTest.testConfigureFetchAfterCloneTask: repository cannot be deleted due to ListNotesCommand
Summary: CloneOperationTest.testConfigureFetchAfterCloneTask: repository cannot be del...
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: Core (show other bugs)
Version: 5.7   Edit
Hardware: PC Windows All
: P3 minor (vote)
Target Milestone: 5.8   Edit
Assignee: Michael Keppler CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-15 07:21 EDT by Michael Keppler CLA
Modified: 2020-04-17 09:20 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Keppler CLA 2020-04-15 07:21:03 EDT 
org.eclipse.egit.core.test.op.CloneOperationTest.testConfigureFetchAfterCloneTask fails on Windows (because of some pack file still being locked). It succeeds if the ListNotesCommand in line 193 is not called. Be aware that in the same test an AddNoteCommand is called (line 201) without causing an issue.

Since someone fixed all the other issues related to pack files, maybe this is worth an investigation, too?

If the issue cannot be fixed easily, would others be okay with using JUnit Assume to not execute this test on Windows? I would really like to see a fully green test execution on Windows (even with using Assume) before starting to switch to JUnit 5.
Comment 1 Thomas Wolf CLA 2020-04-16 03:09:10 EDT 
The tests in CloneOperationTest all neglect to close the cloned repo. They should.
Comment 2 Michael Keppler CLA 2020-04-16 04:15:01 EDT 
(In reply to Thomas Wolf from comment #1)
> The tests in CloneOperationTest all neglect to close the cloned repo. They
> should.

I think that's okay. The repository1 member is a protected one and will be cleaned up by the super class.

Also it is really sufficient to remove the line 193 to make _all_ test cases become green (while 4 are red for me right now).
Comment 3 Thomas Wolf CLA 2020-04-16 04:20:02 EDT 
I'm not talking about repository1. I'm talking about the clone created from that.
Comment 4 Eclipse Genie CLA 2020-04-16 11:57:51 EDT 
New Gerrit change created: https://git.eclipse.org/r/161088
Comment 5 Eclipse Genie CLA 2020-04-17 09:19:26 EDT 
Gerrit change https://git.eclipse.org/r/161088 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=e1a202faf9b2811c75bbe7f100930d28302120ae