Bug 562982 - "Commit and Push" in staging view opens dialog without setting remote and selection combo has no proposal
Summary: "Commit and Push" in staging view opens dialog without setting remote and sel...
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 5.8   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-08 17:29 EDT by Mickael Istria CLA
Modified: 2020-05-11 10:57 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mickael Istria CLA 2020-05-08 17:29:45 EDT
I have many many repositories with the only remote being a Gerrit repo. It's often named 'eclipse', sometimes, it's still 'origin'.
It seems like EGit manages to detect that, because in those cases, the "Commit and Push..." button shows the review icon, and clicking it opens the Gerrit push wizard.

But the remote part of the dialog is always empty. Worse, the combo box to select a remote shows no proposal (although I have only 1 remote defined...).

The only solution I see is to close the dialog, get back to the Project Explorer (because the staging view doesn't allow direct push, see bug 512457), find the right project, and do right-click > Push... to get the generic push wizard which is usable.
That consumes a lot of clicks, moves mouse in many places, needs to switch views and contexts, and interrupts the flow of thoughts.
Comment 1 Mickael Istria CLA 2020-05-08 17:31:55 EDT
OK, so I just realized that EGit does use the Gerrit push dialog because there is a change-id. It's a good thing, it's just the push dialog itself not being smart enough.
Comment 2 Eclipse Genie CLA 2020-05-08 18:04:54 EDT
New Gerrit change created: https://git.eclipse.org/r/162735
Comment 3 Eclipse Genie CLA 2020-05-09 17:35:56 EDT
Gerrit change https://git.eclipse.org/r/162735 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=a7a27f2aa1e8081c448daa72089c36116ca5192b
Comment 4 Thomas Wolf CLA 2020-05-09 18:06:50 EDT
Thanks for the fix, Mickael!
Comment 5 Mickael Istria CLA 2020-05-11 10:57:14 EDT
I upgraded to EGit snapshot earlier today, and I think I already saved ~15 minutes of raw time (without counting the induced cost of switching views moving attention and time it takes to come back to initial state) today thanks to this change. The return on investment of this contribution is really high for me. Thanks Thomas for your prompt reviews making it possible!