Bug 563167 - UI freeze of 600 ms in org.eclipse.egit.ui.internal.staging.StagingView.setStagingViewerInput
Summary: UI freeze of 600 ms in org.eclipse.egit.ui.internal.staging.StagingView.setSt...
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: 5.8   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 560449
  Show dependency tree
 
Reported: 2020-05-14 07:36 EDT by Lars Vogel CLA
Modified: 2020-05-19 02:57 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2020-05-14 07:36:15 EDT
Got this UI freeze under Windows with a new workspace, while selecting a Git repository and having the Git Staging view open:

Stack Trace
	at java.base@11.0.7/java.lang.String.equals(String.java:1009)
	at org.eclipse.egit.ui.internal.staging.StagingEntry.equals(StagingEntry.java:368)
	at java.base@11.0.7/java.util.LinkedHashMap.containsValue(LinkedHashMap.java:417)
	at java.base@11.0.7/java.util.LinkedHashMap$LinkedValues.contains(LinkedHashMap.java:598)
	at org.eclipse.egit.ui.internal.staging.StagingView.updateSelection(StagingView.java:2530)
	at org.eclipse.egit.ui.internal.staging.StagingView.setStagingViewerInput(StagingView.java:2305)
	at org.eclipse.egit.ui.internal.staging.StagingView.lambda$19(StagingView.java:3824)
	at org.eclipse.egit.ui.internal.staging.StagingView$$Lambda$1094/0x000000001e11e4a8.run(Unknown Source)
	at org.eclipse.egit.ui.internal.staging.StagingView$56.runInUIThread(StagingView.java:4442)
	at org.eclipse.ui.progress.UIJob.lambda$0(UIJob.java:95)
	at org.eclipse.ui.progress.UIJob$$Lambda$595/0x0000000011ee80a8.run(Unknown Source)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:40)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:185)
	at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3899)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3529)
	at org.eclipse.jface.window.Window.runEventLoop(Window.java:823)
	at org.eclipse.jface.window.Window.open(Window.java:799)
	at org.eclipse.ui.internal.views.log.EventDetailsDialog.open(EventDetailsDialog.java:191)
	at org.eclipse.ui.internal.views.log.EventDetailsDialogAction.run(EventDetailsDialogAction.java:102)
	at org.eclipse.ui.internal.views.log.LogView.lambda$2(LogView.java:591)
	at org.eclipse.ui.internal.views.log.LogView$$Lambda$1128/0x000000001e2f5040.doubleClick(Unknown Source)
	at org.eclipse.jface.viewers.StructuredViewer$1.run(StructuredViewer.java:782)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:45)
	at org.eclipse.ui.internal.JFaceUtil$$Lambda$69/0x000000001118f440.run(Unknown Source)
	at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:174)
	at org.eclipse.jface.viewers.StructuredViewer.fireDoubleClick(StructuredViewer.java:779)
	at org.eclipse.jface.viewers.AbstractTreeViewer.handleDoubleSelect(AbstractTreeViewer.java:1526)
	at org.eclipse.jface.viewers.StructuredViewer$4.widgetDefaultSelected(StructuredViewer.java:1213)
	at org.eclipse.jface.util.OpenStrategy.fireDefaultSelectionEvent(OpenStrategy.java:251)
	at org.eclipse.jface.util.OpenStrategy.access$0(OpenStrategy.java:249)
	at org.eclipse.jface.util.OpenStrategy$1.handleEvent(OpenStrategy.java:308)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:89)
	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4107)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1037)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3924)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3526)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1160)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:338)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1049)
	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:155)
	at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:658)
	at org.eclipse.ui.internal.Workbench$$Lambda$188/0x000000001455e4a8.run(Unknown Source)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:338)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:557)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:154)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:150)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:203)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:137)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:107)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:401)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:255)
	at java.base@11.0.7/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base@11.0.7/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base@11.0.7/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base@11.0.7/java.lang.reflect.Method.invoke(Method.java:566)
	at app//org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:657)
	at app//org.eclipse.equinox.launcher.Main.basicRun(Main.java:594)
	at app//org.eclipse.equinox.launcher.Main.run(Main.java:1447)
Comment 1 Thomas Wolf CLA 2020-05-15 07:47:24 EDT
Gerrit isn't reporting here: see https://git.eclipse.org/r/#/c/163082/ .
Comment 2 Eclipse Genie CLA 2020-05-19 02:43:55 EDT
Gerrit change https://git.eclipse.org/r/163082 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=24a28bdaa03e9bb28cb3663e17241c50c4abe1e0
Comment 3 Lars Vogel CLA 2020-05-19 02:57:27 EDT
Thanks, Thomas.