Community
Participate
Working Groups
This preference setting should be stored in the EGit Core preferences, not in the UI preferences. Migration must not break existing setups. Having the preference in the core preferences would allow the ProjectReferenceImporter to use it. Currently it uses a hard-coded time-out of 60 seconds.
Your suggestion is clean, but has a certain risk of other people referencing the old settings value in oomph setups and the like. Couldn't we instead ask the PreferenceService from the importer to read the value from the UI plugin preference store? Assuming a normal egit installation that should always work well, even though it's an access violating the architectural dependencies.
Yuck. First, AFAIK preferences and where and how they are stored are not API. Anyone accessing our preferences via the IPreferencesService is welcome to do so, but he must not make any assumptions that the preference names would be stable. Second, I had thought of copying the preference from the UI prefs to the Core prefs (if it doesn't exist in core already) and then removing it from the UI prefs in the UI Activator. So if an Oomph setup sets the pref in UI, it won't be in core, and the Activator will copy it. If a later Oomph setup check re-adds the pref in UI, that's redundant and won't ever be read, but since the it's been copied to the core prefs already, it doesn't hurt either. Should be transparent for Oomph users, shouldn't it?
The preference key must change to "core_remote_connection_timeout" when it's migrated.
New Gerrit change created: https://git.eclipse.org/r/c/egit/egit/+/165838
Gerrit change https://git.eclipse.org/r/c/egit/egit-github/+/169981 was merged to [master]. Commit: http://git.eclipse.org/c/egit/egit-github.git/commit/?id=3f95acdae6802f13977954230fb62b97eadc72d9
https://git.eclipse.org/r/c/egit/egit/+/165838 was merged as well
New Gerrit change created: https://git.eclipse.org/r/c/egit/egit-github/+/169981
