Bug 563986 - No diff editor quick outline shortcut in preferences
Summary: No diff editor quick outline shortcut in preferences
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 5.8   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-05 09:13 EDT by Martin Coufal CLA
Modified: 2020-06-15 07:41 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Coufal CLA 2020-06-05 09:13:14 EDT 
Shortcut `ctrl+O` opens quick outline in diff editor, but there is no option to change or disable this in preferences (or at least I haven't found it).

How to reproduce:
1. have a project shared with Git
2. make sure at least two commits are present
3. open History view, select repository with the project
4. in History view, select at least two commits
5. right click and click 'Show Unified Diff'
6. click in opened diff editor
7. press 'ctrl+O'

There is no record for this shortcut in preferences and it's not possible to change it.


My configuration:
Eclipse Platform I20200530-0600
Eclipse EGit 5.8.0.202006010532
Comment 1 Eclipse Genie CLA 2020-06-05 18:01:25 EDT 
New Gerrit change created: https://git.eclipse.org/r/164317
Comment 2 Thomas Wolf CLA 2020-06-05 18:04:34 EDT 
That's because the command lacks a category. Click the "Filter..." button, uncheck the "Filter uncategorized commands" checkbox. Then it should appear.

(In reply to Eclipse Genie from comment #1)
> New Gerrit change created: https://git.eclipse.org/r/164317

This adds the missing category (and fixes some other minor problems with that command).
Comment 3 Eclipse Genie CLA 2020-06-06 04:32:27 EDT 
Gerrit change https://git.eclipse.org/r/164317 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=82b422cadd439306d7ddce6e6d76225c448fb92f
Comment 4 Martin Coufal CLA 2020-06-15 07:41:42 EDT 
Thanks, just verified, category (and description) is present, and key conflicts are gone as well.