NEW DATE! Bugzilla will undergo maintenance 2024-03-28 18h00 CET. Bugzilla will be placed in read-only mode at that time.

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 566760 - Better "Delete the selected files from the file system" text in the dialog
Summary: Better "Delete the selected files from the file system" text in the dialog
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: 5.10   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-08 03:46 EDT by Lars Vogel CLA
Modified: 2020-10-30 19:47 EDT (History)
4 users (show)

See Also:


Attachments
Screenshot (9.77 KB, image/png)
2020-09-08 03:46 EDT, Lars Vogel CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2020-09-08 03:46:26 EDT
Created attachment 284077 [details]
Screenshot

If I delete files from the staging area, the dialog text is a bit long:

"Delete the selected files from the file system" feels a bit redundant, maybe we can use: "Delete the selected files?"

Also the dialog title could IMHO be improved. Instead of the "Delete Files" titel maybe we can say "Delete uncommitted files" to make it clearer what is happening.
Comment 1 Lars Vogel CLA 2020-10-02 04:51:05 EDT
Chenhui, please provide Gerrit
Comment 2 Chenhui Xu CLA 2020-10-08 07:39:37 EDT
When I try to reproduce this problem, the dialog comes when I delete file directly from file explorer, not in staging area.
Comment 3 Eclipse Genie CLA 2020-10-14 06:03:37 EDT
New Gerrit change created: https://git.eclipse.org/r/c/egit/egit/+/170761
Comment 4 Chenhui Xu CLA 2020-10-14 06:06:56 EDT
Lars, the delete action from file explorer and staging area are handled by the same function.

I can try to look if this can be done by extending specific function or passing some parameters.
Comment 5 Eclipse Genie CLA 2020-10-29 15:07:34 EDT
New Gerrit change created: https://git.eclipse.org/r/c/egit/egit/+/171481