567557 – Prepare for Github shutting down Basic auth

Bug 567557 - Prepare for Github shutting down Basic auth

Summary: Prepare for Github shutting down Basic auth

Status:	RESOLVED FIXED

Alias:	None

Product:	EGit
Classification:	Technology
Component:	GitHub (show other bugs)
Version:	5.9
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	5.10
Assignee:	Project Inbox
QA Contact:

URL:
Whiteboard:
Keywords:

Duplicates (2):	426144 558444 (view as bug list)
Depends on:
Blocks:

Reported:	2020-10-02 15:55 EDT by Thomas Wolf
Modified:	2020-10-06 06:54 EDT (History)
CC List:	2 users (show)

See Also:	558444 Gerrit Change Git Commit Gerrit Change Gerrit Change Gerrit Change Git Commit Git Commit Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Thomas Wolf

2020-10-02 15:55:09 EDT

See https://developer.github.com/changes/2020-02-14-deprecating-password-auth/ .

GitHubClient does have a setOAuth2Token() method that can be used. But it's not used in the egit-github code; and the underlying Mylyn AuthenticationCredentials that are used by egit-github are also username/password.

Not sure how much work this would be, and what changes, if any, this might need in Mylyn.

Comment 1 Eclipse Genie

2020-10-04 10:44:52 EDT

New Gerrit change created: https://git.eclipse.org/r/c/egit/egit-github/+/170282

Comment 2 Eclipse Genie

2020-10-04 15:46:41 EDT

Gerrit change https://git.eclipse.org/r/c/egit/egit-github/+/170282 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit-github.git/commit/?id=23dd27bc5a66f47054903fdb5d0e9b06330227af

Comment 3 Thomas Wolf

2020-10-05 19:55:57 EDT

*** Bug 426144 has been marked as a duplicate of this bug. ***

Comment 4 Eclipse Genie

2020-10-06 03:06:43 EDT

Gerrit change https://git.eclipse.org/r/c/egit/egit-github/+/170342 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit-github.git/commit/?id=8c0e69877e7aad6d3ec6f17a292e7ec13eb1c0fe

Comment 5 Eclipse Genie

2020-10-06 03:06:44 EDT

Gerrit change https://git.eclipse.org/r/c/egit/egit-github/+/170341 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit-github.git/commit/?id=9cf32aab3679d1f36a43addee7a8d88833d6d7d8

Comment 6 Eclipse Genie

2020-10-06 03:06:46 EDT

Gerrit change https://git.eclipse.org/r/c/egit/egit-github/+/170343 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit-github.git/commit/?id=6aea97a98ce571866ac5338269b15686f9923b9e

Comment 7 Thomas Wolf

2020-10-06 06:52:04 EDT

Documentation is updated, too: https://wiki.eclipse.org/EGit/GitHub/User_Guide#Credentials .

Closing for now; if there are specific problems please open new issues.

Comment 8 Thomas Wolf

2020-10-06 06:54:16 EDT

*** Bug 558444 has been marked as a duplicate of this bug. ***