Description Thomas Wolf 2021-01-29 11:20:58 EST

See https://www.eclipse.org/forums/index.php/t/1106764/ .

If a repo contains already committed files that later were subject to LFS, they must be passed through.

SmudgeFilter currently always tries to read files as LFS pointers, and always just closes the original InputStream. That won't work.

Example:

git add something.tar
git commit
...
later, maybe much later, the repo is switched to LFS:
echo '*.tar filter=lfs diff=lfs merge=lfs -text' >> .gitattributes
git add .gitattributes
git commit

Now try to clone that repo. SmudgeFilter will parse the tar file, not find a LFS pointer, and close the input stream. The file cannot be checked out, or will be checked out empty.

SmudgeFilter must reset the original input stream if it doesn't contain an LFS pointer. LFSPointer must check more carefully whether something actually looks like a LFS pointer.